Use Standard SKU for public IP addresses #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the API version for public IP addresses and enforced the Standard SKU to avoid Azure quota issues.
Member
|
thank you for the assist! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1 of 3 - Use Standard SKU for public IP addresses
I needed 3 small changes to get the do-lab to deploy. I'm doing 3 even smaller pr.
Tested in my fork over at: https://github.com/dpcybuck/DO-LAB
First - force azure to assign public IP addresses of standard SKU, i was running into an error where my basic public IP address quota was 0, and could not increase it (documentation was saying basic is deprecated or similar)
Forked this repo, made edits to
The edits also include an update to the "apiVersion" in the resource definition.
If you go look at my main branch of the fork, over at: https://github.com/dpcybuck/DO-LAB
Your going to see a lot of search replace changes.
To test this I needed to change all the references to this DefensiveOrigions/DO-LAB /main and /raw/main to point to my repo so that as the arm's and scripts were running they pointed to the modified "azuredeploy-ad.json" and other things.
To test I had to change the encoded URL in readme.md and readme.html to also, point to dpcybuck/DO-LAB fork
Because of permissions I can't create a branch here. But with 3 changes. I was able to execute the DO-LAB deploy from my fork.