Feature/refactor #50
Open
Feature/refactor #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Write-Host is correct in this situation. It's rare but in this case it is correct because we are truly trying to convey information to the Azure DevOps log host and not the rest of our script/task. Check out PowerShell streams to learn more if you are interested. |
Dejulia489
requested changes
Jul 23, 2020
Owner
Dejulia489
left a comment
Dejulia489
left a comment
There was a problem hiding this comment.
I recommend we stick with Write-Host in this case. I also had a few questions that you could have already tested and are able to answer.
Thanks
Contributor
Author
|
@Dejulia489 do you need any more to accept this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed sequence of invoke-command to fix Deployment Group issue
Replaced Write-Host with Write-Output (http://www.jsnover.com/blog/2013/12/07/write-host-considered-harmful/)
Fixed #42