Conversation
|
if we do want a custom filter, this is what I did before realising we probably don't need it 7bab12b |
|
This code seems fine but I have two questions:
I think we need to answer 1 before working on 2. @pmk01 I'd like your reckons on this too please |
|
I'll wait for Peter to chime in before doing anything more on the editing UI. Did you have any thoughts on the filters? Shall we just roll with the defaults like I have suggested? That will be the same whatever we do on the edit side. |
|
Yeah, I think the current filters are fine for the data export. We might want a way to filter candidates in the front end, e.g to allow people to go through and edit people with missing names. I think we should punt that to a new PR as it also needs a little chat about how to make it useful. |
|
Here's another thing to think about, which I think is relevant here: Currently there are some things that are an attribute of a Person, but they should really be attributes of a Candidacy. The most obvious one is candidate statement. If you imagine a world where we have moved to storing statement as an attribute of a Candidacy, I think what we would actually want is the ability to edit a candidacy (i.e: Joe Bloggs standing in ballot In that world, I think I would squarely think of "name exactly as it appears on the SOPN" as something that squarely goes in the "edit candidacy" form rather than the "edit person names" form. Obviously that is kind of a hypothetical, but I reckon it is worth bearing that in mind as a direction of travel. |
This PR allows us to edit the SOPN names fields on the inline membership form
These forms are only available if the ballot has a SOPN
The other thing we said we wanted was a way to identify records that don't have the SOPN names set. I started off thinking I would need to implement a custom filter for this. Then after I did it, I realised that we actually kind of get this out of the box. If you add any custom fields to the builder, you automatically get boolean filters for them. So for example:
I think I'm fine with just leaving it there tbh. That said, if we want a combined filter for both fields I still have the code I wrote to hand.