Fixing issues reported at #160 and #161.#162
Merged
leonelsanchesdasilva merged 2 commits intomainfrom Feb 4, 2026
Merged
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success569 tests passing in 60 suites. Report generated by 🧪jest coverage report action from 1c68ad1 |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes two related bugs with <xsl:element> behavior inside loops, as reported in issues #160 and #161. Issue #160 caused <xsl:element> inside <xsl:for-each> to repeat the first item's content for all iterations, while issue #161 caused incorrect ordering when mixing <xsl:element> with literal tags.
Changes:
- Added test cases for both issues verifying correct context preservation and element ordering
- Fixed context preservation in
xsltElementby removing explicit position reset - Added
siblingPositiontracking to preserve document order for dynamically generated elements
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/gh_issues_160_161.test.tsx | New test file with two test cases validating that xsl:element works correctly inside loops and maintains proper ordering with literal tags |
| src/xslt/xslt.ts | Fixed xsltElement to preserve context (line 1341) and set siblingPosition before appending (line 1336) to maintain document order |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<xsl:element>inside a loop renders unique content for each item.<xsl:element>and literal tags appear in the correct interleaved order.Resolves #160 and #161.