Implementing configurable fetch#173
Merged
leonelsanchesdasilva merged 3 commits intomainfrom Feb 11, 2026
Merged
Conversation
Coverage report
Test suite run success620 tests passing in 61 suites. Report generated by 🧪jest coverage report action from 9d147f8 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable loader for external stylesheets so <xsl:import> / <xsl:include> no longer depend strictly on globalThis.fetch, addressing issue #172’s request to allow custom loading/denial of external resources.
Changes:
- Introduces
fetchFunctiononXsltOptionsand theXsltclass to customize external resource loading. - Routes
<xsl:import>/<xsl:include>loading throughthis.fetchFunction(...)instead of directly usingglobalThis.fetch. - Documents the new option in the README with usage examples.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/xslt/xslt.ts | Adds fetchFunction initialization and uses it for import/include loading. |
| src/xslt/types.ts | Extends XsltOptions with optional fetchFunction. |
| README.md | Documents fetchFunction and provides examples for deny/local/remap strategies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #172