Conversation
| } | ||
| }; | ||
|
|
||
| var DATA_KEY = 'swpr'; |
There was a problem hiding this comment.
Can you use swiper as a key ? or this is already taken by the lib ?
|
|
||
| return { | ||
| init: init, | ||
| reset: reset |
There was a problem hiding this comment.
Should include a destroy method
| return config; | ||
| }; | ||
|
|
||
| var init = function (element) { |
There was a problem hiding this comment.
Our init methods always need a second params to add/override the default config of the swiper instence
There was a problem hiding this comment.
See flickity.js for reference
| return obj; | ||
| }; | ||
|
|
||
| var getConfig = function (element, prefix) { |
There was a problem hiding this comment.
It doesn't support nested options.
There was a problem hiding this comment.
ok, will update computeOptions to support this. Still use it tho.
|
|
||
| 'use strict'; | ||
|
|
||
| App.components.exports('swiper', function (s) { |
There was a problem hiding this comment.
We should be able to override default config too via s
fhamon
requested review from
ArnaudCrevier,
SamStamkos,
alexnantel88,
beaubbe,
dominic-blain,
emmacharp,
f-elix,
fhamon and
nitriques
| var nestedConfigs = [ | ||
| 'navigation', | ||
| 'scrollbar', | ||
| 'pagination', | ||
| 'thumbs', | ||
| 'autoplay', | ||
| 'keyboard' | ||
| ]; |
There was a problem hiding this comment.
Do you think that we should add all the Nested Configs available ? ex : mousewheel
If you think so, there's more that we can add ;)
Thank you
There was a problem hiding this comment.
Maybe we should define which one is added by default :)
@nitriques @fhamon @emmacharp @dominic-blain @fstgerm @alexnantel88 @f-elix @beaubbe
3 participants
No description provided.