This repository was archived by the owner on Feb 12, 2021. It is now read-only.
Ignore query string for canonical and title updater#409
Open
beaubbe wants to merge 2 commits intoDeuxHuitHuit:devfrom
Open
Ignore query string for canonical and title updater#409beaubbe wants to merge 2 commits intoDeuxHuitHuit:devfrom
beaubbe wants to merge 2 commits intoDeuxHuitHuit:devfrom
Conversation
nitriques
approved these changes
May 19, 2020
nitriques
requested review from
ArnaudCrevier,
SamStamkos,
alexnantel88,
dominic-blain,
emmacharp,
f-elix and
fstgerm
Member
|
@fhamon ? |
fhamon
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore query string when storing a title because when used, it is compared againt window.location.pathname which does not contain the query string.