-
Notifications
You must be signed in to change notification settings - Fork 23
Mobile HomeScreen Skeleton Loading #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Devasy
wants to merge
1
commit into
main
Choose a base branch
from
jules-mobile-skeleton-loading-3843920602222351459
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import React from 'react'; | ||
| import { View, StyleSheet } from 'react-native'; | ||
| import { Card } from 'react-native-paper'; | ||
| import Skeleton from '../ui/Skeleton'; | ||
|
|
||
| const GroupListSkeleton = () => { | ||
| return ( | ||
| <View | ||
| style={styles.list} | ||
| accessibilityRole="progressbar" | ||
| accessibilityLabel="Loading groups list" | ||
| > | ||
| {[1, 2, 3, 4, 5].map((key) => ( | ||
| <Card key={key} style={styles.card}> | ||
| <Card.Title | ||
| title={<Skeleton width={120} height={20} />} | ||
| left={(props) => ( | ||
| <Skeleton width={40} height={40} borderRadius={20} style={props.style} /> | ||
| )} | ||
| /> | ||
| <Card.Content> | ||
| <Skeleton width={200} height={16} style={{ marginTop: 4 }} /> | ||
| </Card.Content> | ||
| </Card> | ||
| ))} | ||
| </View> | ||
| ); | ||
| }; | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| list: { | ||
| padding: 16, | ||
| }, | ||
| card: { | ||
| marginBottom: 16, | ||
| }, | ||
| }); | ||
|
|
||
| export default GroupListSkeleton; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import React, { useEffect, useRef } from 'react'; | ||
| import { Animated, StyleSheet, View } from 'react-native'; | ||
| import { useTheme } from 'react-native-paper'; | ||
|
|
||
| const Skeleton = ({ width, height, borderRadius, style }) => { | ||
| const theme = useTheme(); | ||
| const opacity = useRef(new Animated.Value(0.3)).current; | ||
|
|
||
| useEffect(() => { | ||
| const animation = Animated.loop( | ||
| Animated.sequence([ | ||
| Animated.timing(opacity, { | ||
| toValue: 0.7, | ||
| duration: 800, | ||
| useNativeDriver: true, | ||
| }), | ||
| Animated.timing(opacity, { | ||
| toValue: 0.3, | ||
| duration: 800, | ||
| useNativeDriver: true, | ||
| }), | ||
| ]) | ||
| ); | ||
|
|
||
| animation.start(); | ||
|
|
||
| return () => animation.stop(); | ||
| }, [opacity]); | ||
|
|
||
| return ( | ||
| <Animated.View | ||
| style={[ | ||
| { | ||
| opacity, | ||
| backgroundColor: theme.colors.surfaceVariant, | ||
| width, | ||
| height, | ||
| borderRadius: borderRadius || 4, | ||
| }, | ||
| style, | ||
| ]} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default Skeleton; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 43
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 82
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 229
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 395
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 294
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 1288
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 95
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 114
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 88
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 1409
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 2609
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 603
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 389
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 129
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 106
🏁 Script executed:
Repository: Devasy/splitwiser
Length of output: 43
🌐 Web query:
react-native-paper v5.14.5 Card.Title title prop React element💡 Result:
In react-native-paper v5.14.5,
Card.Title’stitleprop is typed asReact.ReactNode, but it’s rendered inside a Text component, so in practice it only accepts a string or a<Text>-based node (i.e., content that can legally be nested inside<Text>). Passing something that renders a<View>(e.g., most icons wrapped in a<View>, or any layout container) will trigger the React Native error about nesting<View>inside<Text>. [1][2]What you can do instead
titleas a string /<Text>node, and useleft/rightfor icons/actions. [1]Card.Title’stitle; build your own header row withCard.Content(or a customView) and aText+ icon arrangement. (This avoids the<Text>nesting limitation.) [2]Sources: React Native Paper Card.Title docs [1] and discussion of the practical limitation/error [2].
Remove the
Skeletoncomponent fromCard.Title'stitleprop—it will cause a runtime error.In react-native-paper v5.14.5,
Card.Title'stitleprop is rendered inside a<Text>component. SinceSkeletonreturns anAnimated.View, nesting it insideTextviolates React Native's layout rules and will crash.Fix: Use a string for
titleand move the skeleton to theleftprop (already correct) orrightprop, or restructure withoutCard.Titleif you need full layout control:Example fix: Move title skeleton to Card.Content
🤖 Prompt for AI Agents