Conversation
Collaborator
douglaswinter
left a comment
There was a problem hiding this comment.
This looks good so far but it's an incomplete story. I think there are two bits of state that should be tracked.
- Scan success/failure, but that's more than the initial post/put response, because a scan can fail halfway through. So that should use the events endpoint (or the upcoming glazed subscription), as well as the initial return code. This state would be better tracked as a label ('scan running', 'scan complete' etc) and maybe a green/red light.
- Depending on whether a scan is currently running, we should be disabling one of Submit or Abort buttons.
Contributor
Author
While a scan is running, the |
douglaswinter
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displays response from startTask, as a visual change in the RunPlanButton. Button will be displayed as 'loading' until a response is received, and then either green ('success') or red ('error') for 4 seconds after response is received.
Mocking a 'success' response is default, but either a 'success' or an 'error' can be mocked by adding
?scenario=successor?scenario=errorrespectively to the spectroscopy page url (i.e.http://localhost:5174/spectroscopy?scenario=error). These mocked responses include realistic delay to the http response, to test the button 'loading' state.