Open
Conversation
noemifrisina
approved these changes
Feb 20, 2026
Collaborator
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, I only have one suggestion but as mentioned yesterday I think this is a good start for a first test and we can grow from here
Comment on lines
+20
to
+35
| return ( | ||
| <Button | ||
| variant="contained" | ||
| loading={loading} | ||
| sx={{ width: "150px" }} | ||
| onClick={async () => { | ||
| const taskRequest: TaskRequest = { | ||
| name: name, | ||
| params: params, | ||
| instrument_session: instrumentSession, | ||
| }; | ||
| setLoading(true); | ||
| await createAndStartTask(taskRequest); | ||
| setLoading(false); | ||
| }} | ||
| > |
Collaborator
There was a problem hiding this comment.
Suggested change
| return ( | |
| <Button | |
| variant="contained" | |
| loading={loading} | |
| sx={{ width: "150px" }} | |
| onClick={async () => { | |
| const taskRequest: TaskRequest = { | |
| name: name, | |
| params: params, | |
| instrument_session: instrumentSession, | |
| }; | |
| setLoading(true); | |
| await createAndStartTask(taskRequest); | |
| setLoading(false); | |
| }} | |
| > | |
| const handleClick = () => { | |
| async () => { | |
| const taskRequest: TaskRequest = { | |
| name: name, | |
| params: params, | |
| instrument_session: instrumentSession, | |
| }; | |
| setLoading(true); | |
| await createAndStartTask(taskRequest); | |
| setLoading(false); | |
| } | |
| } | |
| return ( | |
| <Button | |
| variant="contained" | |
| loading={loading} | |
| sx={{ width: "150px" }} | |
| onClick={handleClick} | |
| > |
Could: I think this would make it a bit more readable and easier to change for any bugfix/refactoring that may come later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds i15-1 app, in line with #13