Skip to content

Comments

feat: Add click ParamType to handle JSON parsing#1080

Merged
tpoliaw merged 1 commit intomainfrom
run_plan_cli
Feb 19, 2026
Merged

feat: Add click ParamType to handle JSON parsing#1080
tpoliaw merged 1 commit intomainfrom
run_plan_cli

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Jun 20, 2025

Argument parsing has been moved into a click option validator. This
lets clicks error handling deal with invalid JSON being passed to the
run_plan method instead of having it with the rest of the run logic.

@tpoliaw tpoliaw requested a review from a team as a code owner June 20, 2025 16:20
@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.15%. Comparing base (ddc3f2a) to head (fc3d25b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
- Coverage   95.18%   95.15%   -0.03%     
==========================================
  Files          43       43              
  Lines        3009     3016       +7     
==========================================
+ Hits         2864     2870       +6     
- Misses        145      146       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking so approving but had some comments

@RJCD-Diamond
Copy link
Contributor

Please let me know before this change is merged, because this will break things for me

@DiamondJoseph DiamondJoseph self-requested a review December 8, 2025 17:25
@DiamondJoseph
Copy link
Contributor

Removed my +2 and added the 2.0 label so it shouldn't get merged without consideration (already had feat!)

Argument parsing has been moved into a click option validator. This
lets clicks error handling deal with invalid JSON being passed to the
run_plan method instead of having it with the rest of the run logic.
@tpoliaw
Copy link
Contributor Author

tpoliaw commented Feb 19, 2026

Updated onto recent changes. Change is now limited to the CLI and is no longer breaking. There doesn't seem to be any non-CLI logic left in the CLI though so I think this still closes the original issue.

@tpoliaw tpoliaw changed the title feat!: Remove non-cli logic from cli.run_plan feat: Add click ParamType to handle JSON parsing Feb 19, 2026
Copy link
Contributor

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to run plans and also raise errors when I expect it to.

@tpoliaw tpoliaw removed this from the Blueapi 2.0.0 milestone Feb 19, 2026
@tpoliaw tpoliaw merged commit d0803d1 into main Feb 19, 2026
20 checks passed
@tpoliaw tpoliaw deleted the run_plan_cli branch February 19, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants