Improve HTTP error handling for 401/403 and replace KeyError for 404#1410
Open
harshitnagar22 wants to merge 2 commits intoDiamondLightSource:mainfrom
Open
Improve HTTP error handling for 401/403 and replace KeyError for 404#1410harshitnagar22 wants to merge 2 commits intoDiamondLightSource:mainfrom
harshitnagar22 wants to merge 2 commits intoDiamondLightSource:mainfrom
Conversation
This PR improves HTTP error handling in the client. Changes: - Added explicit handling for 401 (Unauthorized) and 403 (Forbidden) status codes. - Replaced the use of KeyError for 404 responses with a more appropriate API error. - Improved error messages for better clarity and debugging. This aligns error handling more closely with standard HTTP semantics and avoids using KeyError for non-dictionary-related issues. Fixes DiamondLightSource#1409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves HTTP error handling in the client.
Changes:
This aligns error handling more closely with standard HTTP semantics and avoids using KeyError for non-dictionary-related issues.
Fixes #1409