Skip to content

Comments

Set up web UI entry points for jungfrau#1565

Merged
noemifrisina merged 13 commits intomainfrom
151_1200-jungfrau-rotation-ui
Feb 20, 2026
Merged

Set up web UI entry points for jungfrau#1565
noemifrisina merged 13 commits intomainfrom
151_1200-jungfrau-rotation-ui

Conversation

@noemifrisina
Copy link
Contributor

@noemifrisina noemifrisina commented Jan 20, 2026

Part of #151 and #1200

  • Adds an entry point plan for the jungfrau rotation scan
  • Exposes do_dark plans to blueapi so they can be triggered by web ui

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@noemifrisina noemifrisina mentioned this pull request Jan 20, 2026
1 task
@noemifrisina noemifrisina added web ui i24 Changes relating to I24 jungfrau Changes relating to the jungfrau detector labels Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.82%. Comparing base (6520e6e) to head (3b29157).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
+ Coverage   92.81%   92.82%   +0.01%     
==========================================
  Files         153      155       +2     
  Lines        8642     8656      +14     
==========================================
+ Hits         8021     8035      +14     
  Misses        621      621              
Components Coverage Δ
i24 SSX 77.32% <ø> (-1.28%) ⬇️
hyperion 98.22% <ø> (ø)
other 98.20% <100.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noemifrisina noemifrisina marked this pull request as ready for review January 20, 2026 15:53
@noemifrisina noemifrisina requested a review from a team as a code owner January 20, 2026 15:53
Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment but approved. Maybe let's hold off in merging until I've tested with DiamondLightSource/mx-daq-ui#88

CI failure is unrelated - #1574 should fix it.

Comment on lines +26 to +28
# @pytest.fixture
# def enum_attenuator() -> EnumFilterAttenuator:
# return i24.attenuator.build(connect_immediately=True, mock=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should: Remove comment

@noemifrisina noemifrisina merged commit e31a3ff into main Feb 20, 2026
17 checks passed
@noemifrisina noemifrisina deleted the 151_1200-jungfrau-rotation-ui branch February 20, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i24 Changes relating to I24 jungfrau Changes relating to the jungfrau detector web ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants