Merged
Conversation
rtuck99
reviewed
Oct 23, 2025
| /** | ||
| * Opens a dilog showing the calculated laser delay to set for each EAVA setting, given the laser | ||
| * exposure time and collection exposure time. | ||
| * |
There was a problem hiding this comment.
Nit: parameters in these functions don't exactly match the signatures.
rtuck99
reviewed
Oct 23, 2025
| submitAndRunPlanImmediately({ | ||
| planName: props.plan_name, | ||
| planParams: { position: newValue }, | ||
| instrumentSession: "", // FIXME, temporary |
There was a problem hiding this comment.
Should probably reference a GH issue here
rtuck99
reviewed
Oct 23, 2025
| @@ -0,0 +1,124 @@ | |||
| import { Box, Button, Grid2, Stack } from "@mui/material"; | |||
Contributor
Author
There was a problem hiding this comment.
Ah good spot, thanks
rtuck99
reviewed
Oct 23, 2025
| PumpProbeSetup, | ||
| } from "./PumpProbeSelection"; | ||
| import { AbortButton, RunPlanButton } from "../../blueapi/BlueapiComponents"; | ||
| import { DetailsRounded } from "@mui/icons-material"; |
Contributor
Author
There was a problem hiding this comment.
Lol, I'm not even sure where that came from - yay for autocomplete
rtuck99
reviewed
Oct 23, 2025
| parseInstrumentSession, | ||
| readVisitFromPv, | ||
| RunPlanButton, | ||
| } from "../blueapi/BlueapiComponents"; |
There was a problem hiding this comment.
es-lint: buttonStyle on line 264 is not used
rtuck99
approved these changes
Oct 23, 2025
rtuck99
left a comment
rtuck99
left a comment
There was a problem hiding this comment.
Approved with some minor comments to address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Closes #14
Plans in mx-bluesky#1346