Open
Conversation
|
Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/GitNotebooks/demo/pull/4 |
smith-kyle
approved these changes
Dec 3, 2024
smith-kyle
approved these changes
Dec 3, 2024
smith-kyle
approved these changes
Dec 4, 2024
smith-kyle
reviewed
Dec 4, 2024
| raise ValueError("Division by zero is not allowed") | ||
|
|
||
|
|
||
| def modulus(a, b): |
smith-kyle
reviewed
Dec 4, 2024
Member
There was a problem hiding this comment.
One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.).test comment
smith-kyle
reviewed
Dec 4, 2024
Member
There was a problem hiding this comment.
One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.).new review comment
smith-kyle
requested changes
Dec 4, 2024
Member
There was a problem hiding this comment.
raise ValueError("Division by zero is not allowed")
def modulus(a, b):how
smith-kyle
approved these changes
Dec 6, 2024
Member
There was a problem hiding this comment.
# Operating on Data in PandasHey @owen-connor I'm going to ping you for a demo
smith-kyle
approved these changes
Jan 21, 2025
Member
There was a problem hiding this comment.
fill = A.stack().sum()
A.add(B, fill_value=fill)Looks good
Member
There was a problem hiding this comment.
return a * b
def divide(a, b):
if b != 0:
return a / b
else:
raise ValueError("Division by zero is not allowed")another comment
Member
There was a problem hiding this comment.
A = pd.DataFrame(rng.randint(0, 20, (2, 2)),
columns=list('AB'))
B = pd.DataFrame(rng.randint(0, 10, (3, 3)),test
owen-connor
commented
Mar 12, 2025
Author
There was a problem hiding this comment.
Suggested change
| "A = rng.randint(10, size=(4, 4))\n", |
smith-kyle
reviewed
Jun 10, 2025
Comment on lines
+20
to
+21
| def modulus(a, b): | ||
| return a % b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.