My Demo Pull Request by smith-kyle · Pull Request #6 · DiffEnder/demo

smith-kyle · 2025-02-18T21:47:29Z

No description provided.

gitnotebooks-staging · 2025-02-18T21:47:32Z

Found 2 changed notebooks. Review the changes at https://app-staging.gitnotebooks.com/GitNotebooks/demo/pull/6

gitnotebooks · 2025-02-18T21:47:32Z

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/GitNotebooks/demo/pull/6

smith-kyle

Here's my review

smith-kyle

Done

smith-kyle · 2025-02-19T17:27:23Z

pandas-example.ipynb

One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.). Pandas inherits much of this functionality from NumPy, and the ufuncs that we introduced in [Computation on NumPy Arrays: Universal Functions](02.03-Computation-on-arrays-ufuncs.ipynb) are key to this. Pandas includes a couple useful twists, however: for unary operations like negation and trigonometric functions, these ufuncs will *preserve index and column labels* in the output, and for binary operations such as addition and multiplication, Pandas will automatically *align indices* when passing the objects to the ufunc.

markdown comment

smith-kyle · 2025-02-19T17:27:31Z

pandas-example.ipynb

rng = np.random.RandomState(42) A = pd.DataFrame(rng.randint(0, 20, (2, 2)),

another comment

smith-kyle · 2025-02-27T21:16:18Z

pandas-example.ipynb

# Operating on Data in Pandas

Test

smith-kyle · 2025-02-27T21:16:23Z

pandas-example.ipynb

One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.). Pandas inherits much of this functionality from NumPy, and the ufuncs that we introduced in [Computation on NumPy Arrays: Universal Functions](https://gitnotebooks.com/blog) are key to this.

my reply

my actual reply

a reply to the reply

smith-kyle

a review

smith-kyle · 2025-02-28T20:16:55Z

pandas-example.ipynb

not in diff context a = pd.series

smith-kyle · 2025-02-28T20:17:44Z

pandas-example.ipynb

      "metadata": {},
      "source": [
-        "Copied from [https://github.com/jakevdp/PythonDataScienceHandbook](https://github.com/jakevdp/PythonDataScienceHandbook)"
+        "Copied from [https://github.com/jakevdp/PythonDataScienceHandbook](https://github.com/jakevdp/PythonDataScienceHandbook) with modifications to demonstrate notebook diffing."


copied from

smith-kyle · 2025-02-28T20:18:08Z

pandas-example.ipynb

operating on data in pandas on left

smith-kyle

My review is done

smith-kyle · 2025-02-28T20:45:26Z

sklearn-example.ipynb

-        "editable": true
-      },
-      "source": [
-        "### Unsupervised learning: Dimensionality reduction\n",


unepervised on left

smith-kyle · 2025-02-28T21:51:54Z

pandas-example.ipynb

      "metadata": {},
      "source": [
-        "Copied from [https://github.com/jakevdp/PythonDataScienceHandbook](https://github.com/jakevdp/PythonDataScienceHandbook)"
+        "Copied from [https://github.com/jakevdp/PythonDataScienceHandbook](https://github.com/jakevdp/PythonDataScienceHandbook) with modifications to demonstrate notebook diffing."


Suggested change

"Copied from [https://github.com/jakevdp/PythonDataScienceHandbook](https://github.com/jakevdp/PythonDataScienceHandbook) with modifications to demonstrate notebook diffing."

smith-kyle · 2025-02-28T22:03:54Z

pandas-example.ipynb

+        "fill = A.stack().sum()\n",
        "A.add(B, fill_value=fill)\n",


smith-kyle · 2025-02-28T22:04:22Z

pandas-example.ipynb

        "# Large cells? No problem. Cells are collapsed to showcase the diff\n",
        "# Large cells? No problem. Cells are collapsed to showcase the diff\n",
        "\n",
-        "fill = A.stack().mean()\n",


a reply to it actually

smith-kyle · 2025-03-01T01:20:12Z

pandas-example.ipynb

Suggested change

"fill = A.stack().mean()"

"A.subtract(B, fill_value=fill)",

smith-kyle · 2025-03-01T01:33:34Z

pandas-example.ipynb

      "metadata": {},
      "source": [
-        "Notice that indices are aligned correctly irrespective of their order in the two objects, and indices in the result are sorted.\n",
+        "Observe that the indices align accurately regardless of their sequence in the two objects, and the result's indices are organized in ascending order.\n",


observe that th eindicides

smith-kyle · 2025-03-01T01:34:12Z

pandas-example.ipynb

      "cell_type": "markdown",
      "metadata": {},
      "source": [
-        "Notice that indices are aligned correctly irrespective of their order in the two objects, and indices in the result are sorted.\n",


wowza notice that

pandas-example.ipynb

smith-kyle · 2025-03-07T21:48:30Z

pandas-example.ipynb

      ],
      "source": [
-        "A.add(B, fill_value=0)"
+        "A.subtract(B, fill_value=0.0)\n"


Suggested change

"A.subtract(B, fill_value=0.0)\n"

"A.subtract(B, fill_value=0.0)\n"

smith-kyle

Just a couple comments, please take another look

smith-kyle · 2025-06-11T22:16:21Z

pandas-example.ipynb

-        "## Ufuncs: Operations Between DataFrame and Series\n",
+        "## Ufuncs: Operations Between DataFrame and Series with a changed header\n",
        "\n",
        "When performing operations between a ``DataFrame`` and a ``Series``, the index and column alignment is similarly maintained.\n",


smith-kyle · 2025-06-11T22:17:43Z

pandas-example.ipynb

smith-kyle · 2025-06-11T22:22:12Z

pandas-example.ipynb

        "# Large cells? No problem. Cells are collapsed to showcase the diff\n",
        "\n",
-        "fill = A.stack().mean()\n",
+        "fill = A.stack().sum()\n",


please replace this with .add

smith-kyle added 3 commits January 17, 2024 13:06

Modify the notebooks

31b5e08

Change more markdown

11f2988

Show newly added features

76f98aa

smith-kyle commented Feb 18, 2025

View reviewed changes

smith-kyle commented Feb 19, 2025

View reviewed changes

smith-kyle commented Feb 27, 2025

View reviewed changes

pandas-example.ipynb

Copy link

Member Author

smith-kyle Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Operating on Data in Pandas

Test

smith-kyle commented Feb 27, 2025

View reviewed changes

smith-kyle commented Feb 28, 2025

View reviewed changes

pandas-example.ipynb

Copy link

Member Author

smith-kyle Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in diff context a = pd.series

smith-kyle commented Feb 28, 2025

View reviewed changes

pandas-example.ipynb

Copy link

Member Author

smith-kyle Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operating on data in pandas on left

smith-kyle commented Feb 28, 2025

View reviewed changes

pandas-example.ipynb

Comment on lines +199 to 200

"fill = A.stack().sum()\n",

"A.add(B, fill_value=fill)\n",

Copy link

Member Author

smith-kyle Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my reply

smith-kyle commented Feb 28, 2025

View reviewed changes

smith-kyle commented Mar 1, 2025

View reviewed changes

pandas-example.ipynb

Copy link

Member Author

smith-kyle Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

"fill = A.stack().mean()"

"A.subtract(B, fill_value=fill)",

smith-kyle commented Mar 1, 2025

View reviewed changes

smith-kyle commented Mar 7, 2025

View reviewed changes

pandas-example.ipynb Outdated Show resolved Hide resolved

Update pandas-example.ipynb

f1c0aa3

smith-kyle commented Mar 7, 2025

View reviewed changes

smith-kyle commented Jun 11, 2025

View reviewed changes

smith-kyle assigned owen-connor Jul 31, 2025

	"A.subtract(B, fill_value=0.0)\n"
	"A.subtract(B, fill_value=0.0)\n"

Conversation

smith-kyle commented Feb 18, 2025

Uh oh!

gitnotebooks-staging bot commented Feb 18, 2025

Uh oh!

gitnotebooks bot commented Feb 18, 2025

Uh oh!

smith-kyle left a comment

Choose a reason for hiding this comment

Uh oh!

smith-kyle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smith-kyle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smith-kyle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

smith-kyle Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smith-kyle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smith-kyle Mar 7, 2025 •

edited

Loading