Conversation
devadamf
suggested changes
Apr 16, 2021
| var optionalInt: Int? = nil | ||
| var optionalDouble: Double? = nil | ||
| var date: Date = .init(timeIntervalSince1970: 0) | ||
| var optionalDate: Date? = nil |
There was a problem hiding this comment.
If you want this to be more comprehensive of primitive types we use in the app, maybe add a Bool and optional Bool to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@devadamf, started looking at Unrealm some more. Forked the repo and started adding tests.
Things I would like done before we start trying to implement this in the app
I figure this can be our Friday work for the near future