Skip to content

Fix: latest result ID not saved to query #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rudyryk wants to merge 1 commit into from
Closed

Fix: latest result ID not saved to query #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions dingolytics/tasks/run_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ def enqueue_query( # TODO: Replace older enqueue_query() with this, then rename
metadata: dict | None = None,
) -> TaskResult:
scheduled_query_id = scheduled_query.id if scheduled_query else None
# query_hash = gen_query_hash(query)
# query_lock = f"query:{data_source.id}:{query_hash}"
# with workers.default.lock_task(query_lock):
task = run_query_task(
query=query,
data_source_id=data_source.id,
Expand All @@ -35,7 +32,6 @@ def enqueue_query( # TODO: Replace older enqueue_query() with this, then rename
scheduled_query_id=scheduled_query_id,
metadata=metadata,
)
# TODO: Return existing task result if locked.
return task


Expand All @@ -56,6 +52,7 @@ def run_query_task(
user = _resolve_user(user_id, is_api_key, metadata.get("query_id", 0))
data_source = DataSource.get_by_id(data_source_id)
query_runner = data_source.query_runner

# TODO: Handle 'adhoc' explicitly instead of using `scheduled_query_id`
scheduled_query = (
Query.get_by_id(scheduled_query_id)
Expand Down Expand Up @@ -104,8 +101,9 @@ def run_query_task(
retrieved_at=utcnow(),
)

# updated_query_ids = Query.update_latest_result(query_result)
db.session.commit() # make sure that alert sees the latest query result
Query.update_latest_result(query_result)
db.session.commit()

# for query_id in updated_query_ids:
# check_alerts_for_query_task(query_id)

Expand Down
Loading