Skip to content

Dialog detection: subprocess timeout fix and documentation #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Niaobu wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Dialog detection: subprocess timeout fix and documentation #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a72c210
Add dialog detection and remove safe mode suppression
Niaobu Mar 3, 2026
23d3fd4
Add timeout to subprocess calls in DialogDetector
Niaobu Mar 3, 2026
206d8ff
Add dialog detection documentation
Niaobu Mar 3, 2026
8ad6653
Add progress bar detection to dialog system
Niaobu Mar 4, 2026
0e87264
Add cross-platform progress bar detection (macOS/Linux)
Niaobu Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
185 changes: 185 additions & 0 deletions UnityCtl.Cli/DialogCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,185 @@
using System;
using System.Collections.Generic;
using System.CommandLine;
using System.CommandLine.Invocation;
using System.Linq;
using UnityCtl.Protocol;

namespace UnityCtl.Cli;

public static class DialogCommands
{
public static Command CreateCommand()
{
var dialogCommand = new Command("dialog", "Detect and dismiss Unity Editor popup dialogs");

// dialog list
var listCommand = new Command("list", "List detected popup dialogs");
listCommand.SetHandler((InvocationContext context) =>
{
var projectPath = ContextHelper.GetProjectPath(context);
var json = ContextHelper.GetJson(context);

var dialogs = FindDialogs(context, projectPath);
if (dialogs == null) return; // error already printed

if (json)
{
var infos = dialogs.Select(d => new DialogInfo
{
Title = d.Title,
Buttons = d.Buttons.Select(b => b.Text).ToArray(),
Description = d.Description,
Progress = d.Progress
}).ToArray();

Console.WriteLine(JsonHelper.Serialize(infos));
}
else
{
if (dialogs.Count == 0)
{
Console.WriteLine("No popup dialogs detected.");
}
else
{
Console.WriteLine($"Detected {dialogs.Count} dialog(s):");
Console.WriteLine();
foreach (var dialog in dialogs)
{
Console.Write($" \"{dialog.Title}\"");
if (dialog.Buttons.Count > 0)
{
var buttonLabels = dialog.Buttons.Select(b => $"[{b.Text}]");
Console.Write($" {string.Join(" ", buttonLabels)}");
}
if (dialog.Progress.HasValue)
{
var pct = (int)(dialog.Progress.Value * 100);
Console.Write($" ({pct}%)");
}
if (dialog.Description != null)
Console.Write($" - {dialog.Description}");
Console.WriteLine();
}
}
}
});

// dialog dismiss
var dismissCommand = new Command("dismiss", "Dismiss a popup dialog by clicking a button");

var buttonOption = new Option<string?>(
"--button",
"Button text to click (case-insensitive). If not specified, clicks the first button.");

dismissCommand.AddOption(buttonOption);
dismissCommand.SetHandler((InvocationContext context) =>
{
var projectPath = ContextHelper.GetProjectPath(context);
var json = ContextHelper.GetJson(context);
var buttonText = context.ParseResult.GetValueForOption(buttonOption);

var dialogs = FindDialogs(context, projectPath);
if (dialogs == null) return;

if (dialogs.Count == 0)
{
if (json)
{
Console.WriteLine(JsonHelper.Serialize(new { success = false, error = "No popup dialogs detected" }));
}
else
{
Console.Error.WriteLine("No popup dialogs detected.");
}
context.ExitCode = 1;
return;
}

var dialog = dialogs[0];
if (dialog.Buttons.Count == 0)
{
if (json)
{
Console.WriteLine(JsonHelper.Serialize(new { success = false, error = "Dialog has no buttons" }));
}
else
{
Console.Error.WriteLine($"Dialog \"{dialog.Title}\" has no detectable buttons.");
}
context.ExitCode = 1;
return;
}

// Resolve which button to click
var targetButton = buttonText ?? dialog.Buttons[0].Text;

var clicked = DialogDetector.ClickButton(dialog, targetButton);
if (clicked)
{
if (json)
{
Console.WriteLine(JsonHelper.Serialize(new
{
success = true,
dialog = dialog.Title,
button = targetButton
}));
}
else
{
Console.WriteLine($"Clicked \"{targetButton}\" on \"{dialog.Title}\"");
}
}
else
{
if (json)
{
Console.WriteLine(JsonHelper.Serialize(new
{
success = false,
error = $"Button \"{targetButton}\" not found",
availableButtons = dialog.Buttons.Select(b => b.Text).ToArray()
}));
}
else
{
Console.Error.WriteLine($"Button \"{targetButton}\" not found on \"{dialog.Title}\".");
Console.Error.Write(" Available: ");
Console.Error.WriteLine(string.Join(", ", dialog.Buttons.Select(b => b.Text)));
}
context.ExitCode = 1;
}
});

dialogCommand.AddCommand(listCommand);
dialogCommand.AddCommand(dismissCommand);
return dialogCommand;
}

private static List<DetectedDialog>? FindDialogs(InvocationContext context, string? projectPath)
{
var projectRoot = projectPath != null
? System.IO.Path.GetFullPath(projectPath)
: ProjectLocator.FindProjectRoot();

if (projectRoot == null)
{
Console.Error.WriteLine("Error: Not in a Unity project.");
Console.Error.WriteLine(" Use --project to specify project root");
context.ExitCode = 1;
return null;
}

var unityProcess = EditorCommands.FindUnityProcessForProject(projectRoot);
if (unityProcess == null)
{
Console.Error.WriteLine("Error: No Unity Editor found running for this project.");
context.ExitCode = 1;
return null;
}

return DialogDetector.DetectDialogs(unityProcess.Id);
}
}
Loading