feat: Add multi-verifier support for milestones with approval policies#99
Open
gelluisaac wants to merge 5 commits intoDisciplr-Org:mainfrom
Open
feat: Add multi-verifier support for milestones with approval policies#99gelluisaac wants to merge 5 commits intoDisciplr-Org:mainfrom
gelluisaac wants to merge 5 commits intoDisciplr-Org:mainfrom
Conversation
- Implement database schema for milestones, verifiers, and milestone_verifiers join table - Add approval policy service supporting 'all' (unanimous) and 'majority' (>50%) policies - Create comprehensive API endpoints for milestone management and verifier decisions - Add TypeScript interfaces for all milestone-related types - Integrate milestones routes into main application - Support deadline-based expiration and audit trail for decisions Key features: - Multiple verifiers per milestone with configurable approval policies - Verifier decision tracking with reasoning and timestamps - Real-time status calculation based on policy outcomes - Deadline enforcement with automatic expiration - Complete audit trail for governance compliance API endpoints: - GET/POST /api/milestones - Milestone CRUD operations - POST /api/milestones/:id/decisions - Submit verifier decisions - GET /api/milestones/:id/summary - Decision summary and final status - GET/POST /api/milestones/verifiers - Verifier management
Contributor
Author
|
@1nonlypiece PR ready |
Contributor
Author
|
@1nonlypiece conflicts resolved |
- Resolved conflicts in package.json, src/app.ts, and package-lock.json - Kept our milestones implementation while integrating upstream changes - Combined CORS configuration and route registrations - Merged dependency lists and scripts from both branches
Contributor
Author
|
@1nonlypiece conflicts resolved |
Contributor
|
@gelluisaac Can you resolve the conflicts? |
- Resolved conflicts by keeping our multi-verifier milestone implementation - Integrated upstream database migrations and services - Preserved approval policy service and milestone types - Combined authentication and privacy middleware - Added horizon listener and transaction processing - Integrated organization analytics and vault management - Maintained our comprehensive milestone API with verifier decisions
Contributor
Author
|
@1nonlypiece resolved |
Contributor
|
@gelluisaac Can you resolve the conflicts? |
- Resolved conflicts by keeping our milestone implementation - Integrated upstream enterprise models and sessions - Added notification system and team management - Preserved our multi-verifier milestone API - Combined authentication and privacy middleware - Added monitoring and organization services
Contributor
Author
|
@1nonlypiece conflicts resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key features:
API endpoints:
closes Multi-Verifier Support for Milestones #57