Open
Conversation
Add classes to wrap output of algorithms
Change MCMC and SMC to output MCMCOutput and SMCOutput respectively
Gather particles (and weights) prior to contructing SMCOutput block
Compare samples and weights for equality Needed for unit/regression testing
If values not given, assume equal weights
alecksphillips
force-pushed
the
feat/results-output
branch
from
aaa9bac to
ecfd2ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #52 .
I've also simplified the gathering of outputs on MPI by doing a "gather" before returning the samples (in the form of SMCOutput). This also has the benefit of abstracting the MPI-gathering of samples away from the user.
This can be disabled by setting
gather_all=Falsewhen calling the sampler: