refactor: update get_redis return type and clean up main.py imports#7
Merged
refactor: update get_redis return type and clean up main.py imports#7
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR contains two refactoring changes: relocating the Python path modification to occur before module imports in main.py, and simplifying the Redis type hint in redis_client.py.
- Moved the Python path setup code to execute before imports to ensure proper module resolution
- Removed the generic type parameter
[str]from the Redis type hint for cleaner typing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/main.py | Relocated sys.path.insert() to execute before module imports |
| app/infrastructure/redis_client.py | Simplified Redis return type annotation from Redis[str] to Redis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sguming
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor improvements to the codebase for better reliability and clarity. The main changes involve correcting the type annotation for the Redis client and reorganizing the import logic in the main application file.
Code quality and reliability:
get_redisfunction inapp/infrastructure/redis_client.pyto use the genericRedistype, improving compatibility and type correctness.Code organization:
app/main.py, ensuring proper module resolution before other imports.