Skip to content

Conversation

@mvdbosch
Copy link

For details, see discussion at: #75

@dvenza dvenza self-assigned this Jan 27, 2019
@dvenza
Copy link
Member

dvenza commented Jan 27, 2019

Hi,
Before merging I have a couple of comments that need to be addressed:

  1. You may want to have a look at the changes in the README file, it is ok to mention somewhere in the README that Atos has contributed to the Kubernetes backend, but this is the upstream version, not an Atos fork
  2. you can put the config file under contrib/ and mention in the documentation its presence, so people know it exists and can take a look

Nothing else, no comments on the code itself.
Thanks for contributing!

Daniele

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants