Skip to content

Fix errors for windows. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmestucci wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix errors for windows. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/ofxVideoRecorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ void execThread::threadedFunction() {

//===============================
ofxVideoDataWriterThread::ofxVideoDataWriterThread() {
thread.setName("Video Thread");
//thread.setName("Video Thread");

};
#if defined( TARGET_OSX ) || defined( TARGET_LINUX )
void ofxVideoDataWriterThread::setup(string filePath, lockFreeQueue<ofPixels *> * q) {
Expand Down Expand Up @@ -176,7 +177,7 @@ void ofxVideoDataWriterThread::setPipeNonBlocking() {

//===============================
ofxAudioDataWriterThread::ofxAudioDataWriterThread() {
thread.setName("Audio Thread");
//thread.setName("Audio Thread");
};

#if defined( TARGET_OSX ) || defined( TARGET_LINUX )
Expand Down Expand Up @@ -654,12 +655,10 @@ bool ofxVideoRecorder::setupCustomOutput(int w, int h, float fps, int sampleRate

bool ofxVideoRecorder::runCustomScript(string script)
{
stringstream cmd;
cmd << ffmpegLocation << " -y ";


ofLogNotice("FFMpeg Command") << script << endl;
ffmpegThread.setup(script);
string cmd = ffmpegLocation + " -y " + script;

ofLogNotice("FFMpeg Command") << cmd << endl;
ffmpegThread.setup(cmd);

bIsInitialized = true;

Expand Down