refactor: changes for higher compatibility #2
Conversation
- replaced x-components with components - added missing 200 response for POST request to upload whitelist
- changed known ids/numbers to integers so no float or doubles are created where they are not needed for code generation
…ties - found more numbers that cn be normal integers - added more optional properties for the user
The API endpoint allows for getting the user by ID and by their Username.
…nt to FullUser instead of User
|
I'm going to leave this open for a bit longer since I assume you're implementing things based off of the spec and adding to this pr as you notice issues |
|
I've approved the workflows to run so linting issues show up, you can run it locally with |
|
I think we are done with the fixes. Also, it should now be more in spec than before, this should increase the compatibly to doc generators. We didn't test it tho. You should be able to merge it. |
fix: make warning type nullable at desired locations and change more numbers to integer
DonovanDMC
left a comment
DonovanDMC
left a comment
There was a problem hiding this comment.
Also some consistency issues, single quotes and quoted properties ("$ref")
I need to say, I don't understand what do you mean by that... I search for lines with "$ref" where the value has single quotes but I can't find any... did you mean something else? |
They don't need quotes at all, no properties should the quoted unless they need to be |
|
Also, a while ago, we had the idea it would be interesting to have something like a test user at e621 with that we can execute some integration tests. Something like an additional validation task. |
It's trivial to run an instance of e621ng on your own |
Yeah is a point. Except of that... Are there any other open points I should fix? |
- removed date-time format: e621 sends more data then the format can hold - fixed default_image_size typo - api_regen_multiplier type to be a integer
OpenAPI Restructure
|
Heya, we just did a huge refactor of the API, or rather how it's generated. All tests passed. |
|
I'm going to assume this has been tested further beyond the linting passing, and that I don't need to spend several hours pouring over every detail? |
|
yeah i did :D It's basically just an extraction of the main OpenAPI you wrote with some fixes. |
|
It's failing to load, and the error in the console is completely incomprehensible |
|
Intresting, because the finals openapi not changed alot, but yeah you are right. I can reproduce the error, when I run it local. I will check it. |
|
Seems likely to be a version mismatch in some dependency, my local repository which had not been updated with the dependency changes was able to run the webpack dev just fine, but when installing the newer dependencies it started showing the same issue seen in prod |
|
so, webpack in the new version doesn't works? then whioch method you would prefer to fix this problems? reverting dependencies to the old method or creating a new one for the ui? |
|
As stupid as it sounds, but it works on my machine. I cleaned all my NPM caches and did a clean |
|
So it works fine with pnpm but it shits the bed without it |
|
It indeed does work with pnpm, so looks like we're stuck with that |
4 participants
I wanted to generate a base API for Golang with the Swagger you provided, but the generator didn't understand the x-constants. We had to Fix a few things in the documentation to make it work,