Add function to filter dotbots on get#203
Closed
geonnave wants to merge 2 commits intoDotBots:mainfrom
Closed
Conversation
WilliamTakeshi
approved these changes
Jan 28, 2026
aabadie
reviewed
Jan 28, 2026
| async def get_dotbots(client: RestClient) -> List[DotBotModel]: | ||
| dotbots = await client.fetch_active_dotbots() | ||
| if DOTBOT_ADDR is not None: | ||
| dotbots = [b for b in dotbots if b.address.lower() == DOTBOT_ADDR.lower()] |
Contributor
There was a problem hiding this comment.
Can you describe the logic here? Normally each dotbot has a unique address so as I understand this code, you are limiting to a single dotbot and using a list comprehension for that makes no sense.
Contributor
Author
There was a problem hiding this comment.
This is a quick test while we debug stuff onsite.
It gives ability for both me and William try different control loops in different robots at the same time.
Contributor
Author
|
Closing in favor of #204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @WilliamTakeshi