Skip to content

dotbot/controller: remove unused dotbot-address parameter #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aabadie merged 1 commit into from
Feb 6, 2026
Merged

dotbot/controller: remove unused dotbot-address parameter #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dotbot/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from dotbot import (
CONTROLLER_ADAPTER_DEFAULT,
CONTROLLER_HTTP_PORT_DEFAULT,
DOTBOT_ADDRESS_DEFAULT,
GATEWAY_ADDRESS_DEFAULT,
MAP_SIZE_DEFAULT,
MQTT_HOST_DEFAULT,
Expand Down Expand Up @@ -136,7 +135,6 @@ class ControllerSettings:
mqtt_host: str = MQTT_HOST_DEFAULT
mqtt_port: int = MQTT_PORT_DEFAULT
mqtt_use_tls: bool = False
dotbot_address: str = DOTBOT_ADDRESS_DEFAULT
gw_address: str = GATEWAY_ADDRESS_DEFAULT
network_id: str = NETWORK_ID_DEFAULT
controller_http_port: int = CONTROLLER_HTTP_PORT_DEFAULT
Expand Down
9 changes: 0 additions & 9 deletions dotbot/controller_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from dotbot import (
CONTROLLER_ADAPTER_DEFAULT,
CONTROLLER_HTTP_PORT_DEFAULT,
DOTBOT_ADDRESS_DEFAULT,
GATEWAY_ADDRESS_DEFAULT,
MAP_SIZE_DEFAULT,
MQTT_HOST_DEFAULT,
Expand Down Expand Up @@ -70,12 +69,6 @@
is_flag=True,
help="Use TLS with MQTT (for cloud adapter).",
)
@click.option(
"-d",
"--dotbot-address",
type=str,
help=f"Address in hex of the DotBot to control. Defaults to {DOTBOT_ADDRESS_DEFAULT:>0{16}}",
)
@click.option(
"-g",
"--gw-address",
Expand Down Expand Up @@ -134,7 +127,6 @@ def main(
mqtt_host,
mqtt_port,
mqtt_use_tls,
dotbot_address,
gw_address,
network_id,
controller_http_port,
Expand All @@ -157,7 +149,6 @@ def main(
"mqtt_host": mqtt_host,
"mqtt_port": mqtt_port,
"mqtt_use_tls": mqtt_use_tls,
"dotbot_address": dotbot_address,
"gw_address": gw_address,
"network_id": network_id,
"controller_http_port": controller_http_port,
Expand Down
3 changes: 0 additions & 3 deletions dotbot/tests/test_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ def controller(monkeypatch):
port="/dev/null",
baudrate=115200,
network_id="0",
dotbot_address="456",
gw_address="78",
)
_controller = Controller(settings)
Expand Down Expand Up @@ -203,7 +202,6 @@ async def start_simulator():
settings = ControllerSettings(
adapter="sailbot-simulator",
network_id="0",
dotbot_address="456",
gw_address="78",
controller_http_port=8000,
)
Expand All @@ -226,7 +224,6 @@ async def start_simulator():
settings = ControllerSettings(
adapter="dotbot-simulator",
network_id="0",
dotbot_address="456",
gw_address="78",
controller_http_port=8001,
)
Expand Down
2 changes: 0 additions & 2 deletions dotbot/tests/test_controller_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
-P, --mqtt-port INTEGER MQTT port used by cloud adapter. Default:
1883.
-T, --mqtt-use_tls Use TLS with MQTT (for cloud adapter).
-d, --dotbot-address TEXT Address in hex of the DotBot to control.
Defaults to FFFFFFFFFFFFFFFF
-g, --gw-address TEXT Gateway address in hex. Defaults to
0000000000000000
-s, --network-id TEXT Network ID in hex. Defaults to 0000
Expand Down