Skip to content

controller: split out qrkey client in its own service#207

Open
aabadie wants to merge 7 commits intoDotBots:mainfrom
aabadie:qrkey_client
Open

controller: split out qrkey client in its own service#207
aabadie wants to merge 7 commits intoDotBots:mainfrom
aabadie:qrkey_client

Conversation

@aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 9, 2026

  • functional separate service
  • adapt webfrontend: add logic to choose between qrkey or REST api, re-add REST api helper functions
  • add missing tests

@aabadie aabadie added the enhancement New feature or request label Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 66.18497% with 117 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.87%. Comparing base (aef171e) to head (545dfb1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dotbot/qrkey.py 45.50% 97 Missing ⚠️
dotbot/rest.py 40.00% 15 Missing ⚠️
dotbot/qrkey_app.py 91.42% 3 Missing ⚠️
dotbot/tests/test_qrkey_app.py 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   80.67%   81.87%   +1.20%     
==========================================
  Files          26       30       +4     
  Lines        2716     2907     +191     
==========================================
+ Hits         2191     2380     +189     
- Misses        525      527       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aabadie aabadie changed the title [WIP] controller: split out qrkey client in its own service controller: split out qrkey client in its own service Feb 17, 2026
@geonnave
Copy link
Contributor

Tested REST adapter with 2 bots, it works!

Command used: dotbot-controller -a cloud -H argus.paris.inria.fr -s A000 --map-size 2500x2500 -w

image

@aabadie
Copy link
Contributor Author

aabadie commented Feb 17, 2026

Added partial tests that I think are enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants