Inconsistent state with multiple yellow nodes #576 #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwetzel
requested changes
Mar 10, 2020
Member
jonwetzel
left a comment
jonwetzel
left a comment
There was a problem hiding this comment.
The "dynamic" option is present in the variable node's type menu. Please remove it.
jonwetzel
requested changes
Mar 10, 2020
| <input data-dojo-type="dijit/form/RadioButton" name="variableType" class="handleVariable" id="dynamicType" value="dynamic"/> | ||
| <label for="dynamicType">Dynamic</label> | ||
| </span> | ||
| </span> --> |
Member
There was a problem hiding this comment.
Go ahead and delete the code for this. We can always retrieve it from git if we need it later.
| parameter: "parameterType", | ||
| dynamic: "dynamicType", | ||
| variableType: "variableType", | ||
| //dynamic: "dynamicType", |
Member
There was a problem hiding this comment.
Can delete this dynamic line too.
| registry.byId(prevSelected+"Type").set('checked', false); */ | ||
| var varTypeSel = registry.byId(this.controlMap.variableType); | ||
| varTypeSel.removeOption(varTypeSel.getOptions()); | ||
| var varTypes = ["unknown","parameter","dynamic"]; |
| }); | ||
| } | ||
|
|
||
| // reset the variablte type radio button labels |
Member
There was a problem hiding this comment.
As mentioned before, you can go ahead and remove the radio button code.
Contributor
Author
|
yes, will delete all the corresponding code and other commented out code before merging to master after the testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.