Add multiple registrations if service implements open generic interface more than once#36
Merged
Dreamescaper merged 2 commits intomainfrom Jun 17, 2025
Merged
Conversation
…en generic interfaces
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances service registration generation to handle types implementing multiple matching open generic interfaces.
- FilterTypes now returns all matched assignable types as an array.
- FindServicesToRegister is updated to iterate and register each matched interface.
- Two new tests verify multiple interface registrations and combined self/interface registrations.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.FindServicesToRegister.cs | Updated to unpack and use multiple matched types for service registrations |
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.FilterTypes.cs | Changed filter and assignability checks to return arrays of matched types |
| ServiceScan.SourceGenerator.Tests/AddServicesTests.cs | Added tests for multiple open generic interfaces and renamed an existing test |
Dreamescaper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35 .