Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #37 by excluding non-accessible types from service registration generation. The change ensures that only types accessible from the calling context are included when the source generator scans for services to register.
Key changes:
- Added accessibility checks using
SemanticModel.IsAccessible()to filter out non-accessible types - Refactored
GenerateAttributeSourcetoGenerateAttributeInfowith constants for better maintainability - Added test cases to verify that internal and private classes are properly excluded
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| GenerateAttributeInfo.cs | Renamed class and converted properties to constants for metadata name and source |
| DependencyInjectionGenerator.cs | Updated references to use new class name and constants |
| DependencyInjectionGenerator.FilterTypes.cs | Added accessibility check using semantic model to exclude non-accessible types |
| TestServices.cs | Added internal test class to verify exclusion behavior |
| AddServicesTests.cs | Added private nested class test case with explanatory comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37 .