Find CustomHandler or KeySelector methods if they are defined in base types#42
Merged
Dreamescaper merged 1 commit intomainfrom Aug 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhances the source generator to find CustomHandler and KeySelector methods from base types, not just the containing type directly. This allows inheritance of these methods from parent classes.
- Replaces direct member searches with a new
GetMethodextension method that traverses inheritance hierarchy - Adds accessibility and static context validation using
SemanticModel.IsAccessible - Updates method signature to include
SemanticModelparameter for accessibility checks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ServiceScan.SourceGenerator/Model/AttributeModel.cs | Updates Create method to use new GetMethod extension and pass SemanticModel |
| ServiceScan.SourceGenerator/Extensions/TypeSymbolExtensions.cs | Adds new extension method that searches inheritance hierarchy with accessibility checks |
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.ParseMethodModel.cs | Updates method calls to use new GetMethod extension and refactors loop |
| ServiceScan.SourceGenerator.Tests/CustomHandlerTests.cs | Adds test case verifying inheritance functionality works correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.