fix: Filter out open generics when used with CustomHandler#47
Merged
Dreamescaper merged 2 commits intomainfrom Oct 1, 2025
Merged
fix: Filter out open generics when used with CustomHandler#47Dreamescaper merged 2 commits intomainfrom
Dreamescaper merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to prevent generation of registrations for generic (open) implementation types when a CustomHandler is used, and to improve clarity by using named arguments in service registration construction.
- Add filtering to skip generic types when a CustomHandler is specified.
- Use named arguments for ResolveImplementation and IsOpenGeneric to improve readability.
- Add a unit test and update the playground to demonstrate decorator-based custom handling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.FindServicesToRegister.cs | Switch to named arguments for ResolveImplementation/IsOpenGeneric, clarifying intent in service registration construction. |
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.FilterTypes.cs | Add filter to skip generic types when a CustomHandler is present. |
| ServiceScan.SourceGenerator.Tests/CustomHandlerTests.cs | Add test to validate decorated handler generation for non-generic implementations. |
| ServiceScan.SourceGenerator.Playground/ServiceCollectionExtensions.cs | Update playground to show CustomHandler with decorator pattern. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.