Exec instead of formatting environment variables to eval#12
Open
gabrielg wants to merge 2 commits intoDroplr:masterfrom
Open
Exec instead of formatting environment variables to eval#12gabrielg wants to merge 2 commits intoDroplr:masterfrom
gabrielg wants to merge 2 commits intoDroplr:masterfrom
Conversation
added 2 commits
March 1, 2018 16:22
Contributor
|
Thanks @gabrielg :-) When working on aws-env we also considered such approach but we decided it will be less risky to not rely on Go program (e.g. memory leak on aws-env could cause problems for long running processes). But you are right - on the other hand, eval introduces trickier work with escaping ENV parameters etc. It may be something that we could add as another branch? WDYT? |
Contributor
|
@gabrielg WDYT about adding additional 'exec' options flag? Something like aws-env --exec|-e that won't break backward compatibility and will allow for that superb nice usage :-) |
IcaroBichir
approved these changes
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies
aws-envto set the environment variables andexecthe given command and arguments, rather than forming a string to pass to the shell'seval. This saves us the trouble of having to escape the string for the shell.This PR pretty significantly changes how
aws-envworks, so entirely understood if you'd rather not merge it.