PFP static quick fix #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I have looked through my previous PR for the PFP, the issue is simply taking me too long to fix in this short time I was able to actually sit down and look at it (today). I want to continue to work on this issue, but I have to go to a final from 7:30-10:30 pm today. Since Dr. Cao wants the code today, I figured at least having a static page for her to look at would be better than the Figma or nothing at all.
I have kept the original code from my original PFP PR in the files of this PR, but it is commented out at the bottom of the files. I believe this was the best course of action for the current situation, and assuming other students or faculty may pick up this project after we graduate, the original code is also there for that purpose.
The Components have also been modified with the profile page.