Change debug bad login echo to a more customisable badlogin.php page #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to change behaviour when an incorrect login is used. Rather than a debug query echo, it pulls in a badlogin.php file from the app base directory.
This is an example badlogin page, based on the OwnCloud login page with additional error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this useful - I've submitted the pull request because you might as well. I hope you don't mind. I won't take offence if you reject it.
Test scenario:
In original master. Enter bad username/password. See echo message
In forked master: Enter bad username/password. See OwnCloud login screen with bad credentials message above the sign in form. You can change what happens when a bad login occurs by customising the (new) badlogin.php file.