Fix gpu yuv conversion on godot-stable#31
Open
EgrorBs wants to merge 2 commits intoEIRTeam:masterfrom
Open
Conversation
Contributor
|
I am very sorry for the delay, I was on vacation. Do we need this anymore now that 4.3 has released? |
Author
|
I hope you had a great vacation! :) Personally, I think including this would improve compatibility, which is always a good thing, but it's totally up to you. |
|
@EgrorBs I tested WebM transparent video, which contains BGRA channels, but after decoding with EIRTeam.FFmpeg, the pixels obtained only have BGR channels. The transparent pixels are lost. ` yuva420p (transparent) |
|
@EgrorBs Version v1.1.1 has been released and supports yuva. But it requires ffmpeg to be compiled with --enable-libvpx enabled. Can it be updated to compile an Android extension? https://trac.ffmpeg.org/wiki/Encode/VP9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this fix GPU YUV conversion needs rendering device and Godot 4.3+
Fixes #23
Tested on Godot-stable (4.2.2.stable.official.15073afe3) and Godot-latest (4.3.dev6.official.89850d553) on compat and forward+ renderers