Merge Changes into Main from Canary (v1.4.0-6bae7bf)#37
Open
Marty-Byrde wants to merge 6 commits intomainfrom
Open
Merge Changes into Main from Canary (v1.4.0-6bae7bf)#37Marty-Byrde wants to merge 6 commits intomainfrom
Marty-Byrde wants to merge 6 commits intomainfrom
Conversation
The reason for this change is that when a schema property uses the .transform utility method the type of this property includes ZodEffects. Without handling it in the schemaDefault method it will throw an error.
The reason for this change is that the value of this property can be of type number or null. Given the current definition of number or undefined, when the value is null it is transformed to undefined.
The reason for this change is that fetching invoices may return an empty array, hence the toBeGreaterThan assertions were updated to include equal and greaterThan.
Member
Author
|
🎉 This PR is included in version 1.5.0-canary.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by the Auto-Create-PR-Canary workflow to merge changes from the canary branch into main. These changes are based on v1.4.0 and the latest commit on main (6bae7bf).
This pull request introduces several enhancements and fixes across different parts of the codebase. It includes updates to schema definitions, improvements to API testing, and adjustments to the invoice retrieval process. These changes aim to improve data handling, API testing reliability, and overall application stability.
Schema Updates
schemas/article/RawArticle.ts: Modified thearticle_category_idschema to transformnullvalues toundefined.schemas/utils/schemaDefaults.ts: Added handling forZodEffectsschema types in theschemaDefaultsfunction.API Testing Enhancements
tests/api/Get.test.ts: Added a test to validate theRawCustomersschema against the/usersendpoint and updated the articles test to use a limit of 5, ensuring the response contains at least 5 articles.Invoice Retrieval Improvements
tests/invoices/getInvoices.test.ts: Simplified tests for getting invoices by removing tests for limits of0and-1, and updated the test for the default limit to assert that it returns an array of invoices.