[Operations] Change naming of operands and results to be declarative#577
Open
[Operations] Change naming of operands and results to be declarative#577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While MLIR has named operands and results internally, these values are not accessible as strings. However, to print RTL from our IRs, it is required to access the names of these operands and result programmatically.
Previously, this was done using 3 or 4 different structures, and changes to the code base meant some were in fact wrong. With this PR, every operation must declare how to name its operand and results in its tablegen entry. For complex naming, like the LSQ, the tablegen file points to custom functions in HandshakeOps.cpp