Skip to content

avoid int rounding #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chusx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

avoid int rounding #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
717bcbd
max in 0x notation
chusx Nov 5, 2025
6debac6
no =
chusx Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/src/utils/var_int.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ extension VarIntExtension on ByteData {
this.setUint8(index, _target32);
this.setUint32(index + 1, value);
lengthInBytes = 5;
} else if (value <= 0x7FFFFFFFFFFFFFFF) {
} else if (value < 0x8000000000000000) {
this.setUint8(index, _target64);
this.setUint64(index + 1, value);
lengthInBytes = 9;
} else {
throw new ArgumentError.value(
value, 'value', 'must not exceed 0x7FFFFFFFFFFFFFFF!');
value, 'value', 'must not exceed 0x8000000000000000!');
}
return lengthInBytes;
}
Expand Down