add context attribute containing a reference to the Erddap servlet#436
Merged
ChrisJohnNOAA merged 1 commit intoERDDAP:mainfrom Feb 26, 2026
Merged
Conversation
ChrisJohnNOAA
approved these changes
Feb 26, 2026
Contributor
ChrisJohnNOAA
left a comment
There was a problem hiding this comment.
I definitely support moving to better use the servlet ecosystem and rely less on (ED)static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a servlet context attribute that references the Erddap servlet instance. We use this in other servlets to access the active datasets hashmaps in Erddap. Previously these datasets were in the EDStatic, and we developed servlets that accessed the datasets directly. This allows those servlets to still work.
Type of change
Checklist before requesting a review