Skip to content

add context attribute containing a reference to the Erddap servlet#436

Merged
ChrisJohnNOAA merged 1 commit intoERDDAP:mainfrom
SethChampagneNRL:servlet-context-attribute
Feb 26, 2026
Merged

add context attribute containing a reference to the Erddap servlet#436
ChrisJohnNOAA merged 1 commit intoERDDAP:mainfrom
SethChampagneNRL:servlet-context-attribute

Conversation

@SethChampagneNRL
Copy link
Contributor

@SethChampagneNRL SethChampagneNRL commented Feb 26, 2026

Description

Add a servlet context attribute that references the Erddap servlet instance. We use this in other servlets to access the active datasets hashmaps in Erddap. Previously these datasets were in the EDStatic, and we developed servlets that accessed the datasets directly. This allows those servlets to still work.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@ChrisJohnNOAA ChrisJohnNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely support moving to better use the servlet ecosystem and rely less on (ED)static.

@ChrisJohnNOAA ChrisJohnNOAA merged commit bb63a2a into ERDDAP:main Feb 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants