Fix Parquet boolean columns mapping to NaNs (#26)#437
Open
ChrisJohnNOAA wants to merge 1 commit intoERDDAP:mainfrom
Open
Fix Parquet boolean columns mapping to NaNs (#26)#437ChrisJohnNOAA wants to merge 1 commit intoERDDAP:mainfrom
ChrisJohnNOAA wants to merge 1 commit intoERDDAP:mainfrom
Conversation
* Fix Parquet boolean columns read as NaN in ERDDAP Modified Table.readParquet to explicitly handle BOOLEAN types from Parquet schema, mapping them to ERDDAP's internal byte representation (1=true, 0=false, 127=NaN). Direct use of g.getBoolean() avoids data loss from failed string conversions. Updated CustomWriteSupport.java to correctly interpret ERDDAP's boolean byte representations when writing back to Parquet. Added logic to skip the simplification phase for non-String columns in Table.readParquet to prevent type corruption for boolean columns. Added TableParquetTests.java as a reproduction and regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified Table.readParquet to explicitly handle BOOLEAN types from Parquet schema, mapping them to ERDDAP's internal byte representation (1=true, 0=false, 127=NaN). Direct use of g.getBoolean() avoids data loss from failed string conversions.
Updated CustomWriteSupport.java to correctly interpret ERDDAP's boolean byte representations when writing back to Parquet.
Added logic to skip the simplification phase for non-String columns in Table.readParquet to prevent type corruption for boolean columns.
Added TableParquetTests.java as a reproduction and regression test.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #425
Type of change
Please delete options that are not relevant.
Checklist before requesting a review