Improve DAP HTML form by grouping file types into Data and Image categories#439
Open
vishwas-droid wants to merge 1 commit intoERDDAP:mainfrom
Open
Improve DAP HTML form by grouping file types into Data and Image categories#439vishwas-droid wants to merge 1 commit intoERDDAP:mainfrom
vishwas-droid wants to merge 1 commit intoERDDAP:mainfrom
Conversation
…e preserving default selection behavior
Author
|
hey @ChrisJohnNOAA This implementation keeps the change localized to the current HTML generation logic. |
ChrisJohnNOAA
requested changes
Mar 4, 2026
Contributor
ChrisJohnNOAA
left a comment
There was a problem hiding this comment.
Before making a pull request make sure your changes pass tests (run with mvn verify) and if you're modifying the UI I strongly recommend running the server locally to verify the UI changes (the easiest way to do this is using Jetty, see the documentation in the development/jetty folder).
| writeFunctionHtml( | ||
| request, language, loggedInAs, queryParts, writer, widgets, formName, nOrderByComboBox); | ||
|
|
||
| / writer.write( |
Contributor
There was a problem hiding this comment.
This doesn't even compile. Make sure to verify your changes before making a pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change improves the DAP HTML form by separating file types into clear “Data File Types” and “Image File Types” groups using
<optgroup>.Previously, all file formats were displayed in a single flat dropdown list, which could cause confusion — especially for users expecting raw data formats (e.g., CSV, NetCDF) versus rendered outputs (e.g., PNG, PDF, GeoTIFF images).
This update enhances clarity without modifying any backend logic or request handling behavior. The default file type selection is preserved, and existing functionality remains unchanged.
The goal is purely to improve usability and reduce ambiguity in the output format selection UI.
Fixes #268
Type of change
Checklist before requesting a review