Skip to content

fix: gog cron dom parsing #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Purexo merged 2 commits into from
Apr 16, 2025
Merged

fix: gog cron dom parsing #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
317e216
fix: gog cron dom parsing
Purexo Apr 15, 2025
61e78b4
chore: feedbacks from xstoudi
Purexo Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 36 additions & 16 deletions src/crons/GoG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ export default new Cron({
const embed = new EmbedBuilder()
.setTitle(`GoG - ${game.title}`)
.setURL('https://www.gog.com/#giveaway')
.setDescription(game.description)
.setDescription(
game.description.length > 1000
? game.description.slice(0, 999) + '…'
: game.description,
)
.setImage(game.banner)
.addFields({
name: 'URL du jeu',
Expand Down Expand Up @@ -112,18 +116,20 @@ export async function getOfferedGame(logger: Logger): Promise<Game | null> {
if (!homeBody) return null;
const html = parse(homeBody);
if (!html) return null;
const SEOLink = html.querySelector('a#giveaway');
const giveawayNode = html.querySelector('#giveaway');
if (!giveawayNode) return null;
const SEOLink = giveawayNode.querySelector('a.giveaway__overlay-link');
if (!SEOLink) return null;
const gameURL = SEOLink.getAttribute('href');
if (!gameURL) return null;

const endTimestamp = Number(
html
.querySelector('.giveaway-banner__footer gog-countdown-timer')
?.getAttribute('end-date'),
);

const { body: gameBody } = await got<string>(
`https://www.gog.com${SEOLink.getAttribute('ng-href')}`,
GOG_GOT_OPTIONS,
);
const { body: gameBody } = await got<string>(gameURL, GOG_GOT_OPTIONS);
if (!gameBody) return null;
const gameHTML = parse(gameBody);
if (!gameHTML) return null;
Expand All @@ -135,15 +141,16 @@ export async function getOfferedGame(logger: Logger): Promise<Game | null> {
if (!gameJSON) {
// the gift link redirect to incorrect page
const title =
SEOLink.querySelector('.giveaway-banner__title')?.textContent ??
SEOLink.getAttribute('giveaway-banner-id') ??
giveawayNode.querySelector('.giveaway-banner__title')?.textContent ??
giveawayNode.getAttribute('giveaway-banner-id') ??
'';
const description =
SEOLink.querySelector('.giveaway-banner__description')?.textContent ?? '';
giveawayNode.querySelector('.giveaway-banner__description')
?.textContent ?? '';
const srcset =
SEOLink.querySelector(
'.giveaway-banner__image source[type="image/png"]',
)?.getAttribute('srcset') ?? '';
giveawayNode
.querySelector('.giveaway-banner__image source[type="image/png"]')
?.getAttribute('srcset') ?? '';
/*
* srcset="
* //images-1.gog-statics.com/c26a3d08d01005d92fbc4b658ab226fc5de374d3746f313a01c83e615cc066c1_giveaway_banner_logo_502_2x.png 2x,
Expand Down Expand Up @@ -172,8 +179,9 @@ export async function getOfferedGame(logger: Logger): Promise<Game | null> {
}

const description =
gameHTML.querySelector('.content-summary-item__description')?.textContent ??
'';
gameHTML
.querySelector('.content-summary-section .description')
?.textContent?.trim() ?? '';
const banner =
gameHTML
.querySelector('head meta[property="og:image"]')
Expand All @@ -185,15 +193,27 @@ export async function getOfferedGame(logger: Logger): Promise<Game | null> {
);

const rating = gameJSON.aggregateRating?.ratingValue ?? '?';
let link: string = gameJSON.offers[0].url;
{
const searchIndex = link.indexOf('?');
if (searchIndex !== -1) {
link = link.slice(0, searchIndex);
}
}

const frOffer = gameJSON.offers.find(
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(o: any) => new URL(o.url).searchParams.get('countryCode') === 'FR',
);

return {
title: gameJSON.name.trim(),
description: decode(description),
// link: 'https://www.gog.com/fr#giveaway',
link: gameJSON.offers.url,
link,
thumbnail: gameJSON.image,
banner,
originalPrice: gameJSON.offers.price,
originalPrice: `${frOffer.price} €`,
discountEndDate: new Date(endTimestamp),
rating: `${rating} / 5`,
};
Expand Down
1 change: 1 addition & 0 deletions tests/cron/Gog.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ test('getOfferedGames', async () => {
// expect(game.originalPrice).toBeTruthy();
// expect(typeof game.originalPrice).toBe('string');

// TODO: check the date is valid and find the discountEndDate in GoG pages
expect(game.discountEndDate).toBeTruthy();
expect(game.discountEndDate instanceof Date).toBe(true);

Expand Down