[REFACTOR]: PaymentService 외부 API 호출 로직 분리 by zerochani · Pull Request #91 · Eatsfine/BE

zerochani · 2026-01-31T07:04:42Z

💡 작업 개요

PaymentService의 복잡도를 낮추고 유지보수성을 높이기 위해 외부 API 호출 로직을 별도 서비스 TossPaymentService로 분리했습니다.

✅ 작업 내용

🧪 테스트 내용

./gradlew clean build 성공

Summary by CodeRabbit

Refactor
- Centralized payment integration by moving external payment calls into a dedicated payment service. Confirmation and cancellation flows now use the centralized service with unified error handling and retained validation checks, improving reliability, consistency, and maintainability without changing user-facing payment behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-31T07:05:01Z

📝 Walkthrough

Walkthrough

Extracts Toss API calls into a new TossPaymentService; PaymentService now delegates confirm and cancel operations to that service, preserving existing validation and error handling.

Changes

Cohort / File(s)	Summary
PaymentService refactor `src/main/java/com/eatsfine/eatsfine/domain/payment/service/PaymentService.java`	Replaced direct RestClient usage with a `TossPaymentService` dependency; `confirmPayment` and `cancelPayment` now delegate to service methods; removed in-method REST call logic and try/catch blocks.
New TossPaymentService `src/main/java/com/eatsfine/eatsfine/domain/payment/service/TossPaymentService.java`	Added service encapsulating Toss API interactions with `confirm(dto)` and `cancel(paymentKey, dto)` methods, centralized error handling and logging, injects qualified `RestClient`.

Sequence Diagram(s)

sequenceDiagram
    actor Client
    participant PaymentService as PaymentService
    participant TossService as TossPaymentService
    participant RestClient as tossPaymentClient
    participant TossAPI as "Toss API"

    Client->>PaymentService: confirmPayment(dto) / cancelPayment(...)
    PaymentService->>TossService: confirm(dto) / cancel(paymentKey, dto)
    TossService->>RestClient: POST /v1/payments... (body)
    RestClient->>TossAPI: HTTP request
    TossAPI-->>RestClient: HTTP response
    RestClient-->>TossService: TossPaymentResponse
    TossService-->>PaymentService: TossPaymentResponse
    PaymentService-->>Client: validate response -> proceed / throw

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

[REFACTOR]: PaymentService 외부 API 호출 로직 분리 #88: Matches refactor objective to extract Toss API calls into a dedicated TossPaymentService and remove direct RestClient usage from PaymentService.

Possibly related PRs

[REFACTOR]: 결제 응답 DTO 분리 및 store 용어 통일 #80: Modifies PaymentService.confirmPayment; likely related to combined changes in confirm flow and DTO/mapping.

Suggested reviewers

sonjunkyu
SungMinju
twodo0

Poem

🐰 I hopped through code with nimble paws,
I moved Toss calls behind service doors,
Now PaymentService sends a note,
TossPaymentService takes the float,
Hooray — cleaner hops and fewer bores! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main refactoring change: separating external API call logic from PaymentService into a dedicated service.
Description check	✅ Passed	The description follows the required template structure with all main sections completed: work overview, work type (refactoring checked), and test results provided.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/payment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

PaymentService의 외부 Toss 결제 API 호출 로직을 별도 서비스(TossPaymentService)로 분리해 결제 도메인 서비스의 복잡도를 낮추는 리팩토링입니다.

Changes:

Toss 결제 승인/취소 호출을 담당하는 TossPaymentService 신규 추가
PaymentService에서 RestClient 직접 호출을 제거하고 TossPaymentService로 위임

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/main/java/com/eatsfine/eatsfine/domain/payment/service/TossPaymentService.java	Toss 결제 승인/취소 외부 API 호출을 캡슐화하는 서비스 추가
src/main/java/com/eatsfine/eatsfine/domain/payment/service/PaymentService.java	Toss API 호출 로직을 신규 서비스로 분리하여 의존성/코드 복잡도 감소

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-31T07:08:31Z

src/main/java/com/eatsfine/eatsfine/domain/payment/service/PaymentService.java

                // 토스 API 호출
-                TossPaymentResponse response;
-                try {
-                        response = tossPaymentClient.post()
-                                        .uri("/v1/payments/confirm")
-                                        .body(dto)
-                                        .retrieve()
-                                        .body(TossPaymentResponse.class);
-
-                        if (response == null || !"DONE".equals(response.status())) {
-                                log.error("Toss Payment Confirmation Failed: Status is not DONE");
-                                payment.failPayment();
-                                throw new GeneralException(ErrorStatus._INTERNAL_SERVER_ERROR);
-                        }
-                } catch (Exception e) {
-                        log.error("Toss Payment API Error", e);
+                TossPaymentResponse response = tossPaymentService.confirm(dto);
+
+                if (response == null || !"DONE".equals(response.status())) {
+                        log.error("Toss Payment Confirmation Failed: Status is not DONE");
                        payment.failPayment();
                        throw new GeneralException(ErrorStatus._INTERNAL_SERVER_ERROR);
                }


confirmPayment에서 tossPaymentService.confirm(dto)가 예외(예: RestClient 4xx/5xx, 네트워크 오류)로 GeneralException을 던지면, 현재 로직은 payment.failPayment()를 호출하지 못한 채 메서드가 종료됩니다. 이 메서드는 @Transactional(noRollbackFor = GeneralException.class)이라서 예외가 발생해도 트랜잭션 롤백이 되지 않기 때문에 결제가 PENDING 상태로 남는 회귀가 발생할 수 있습니다. tossPaymentService.confirm(dto) 호출을 try/catch로 감싸서 예외 시에도 payment.failPayment()를 수행한 뒤 예외를 재던지도록 처리해 주세요.

Copilot · 2026-01-31T07:08:32Z

src/main/java/com/eatsfine/eatsfine/domain/payment/service/TossPaymentService.java

+    public TossPaymentResponse cancel(String paymentKey, PaymentRequestDTO.CancelPaymentDTO dto) {
+        try {
+            return tossPaymentClient.post()
+                    .uri("/v1/payments/" + paymentKey + "/cancel")


cancel()에서 URI를 문자열 덧셈으로 만들면 paymentKey에 특수문자/슬래시 등이 포함될 때 인코딩이 깨지거나 의도치 않은 경로가 구성될 수 있습니다. RestClient의 URI 템플릿(예: /v1/payments/{paymentKey}/cancel)이나 UriBuilder를 사용해 path variable로 바인딩하도록 변경해 주세요.

Suggested change

.uri("/v1/payments/" + paymentKey + "/cancel")

.uri("/v1/payments/{paymentKey}/cancel", paymentKey)

Copilot · 2026-01-31T07:08:32Z

src/main/java/com/eatsfine/eatsfine/domain/payment/service/TossPaymentService.java

+    private final RestClient tossPaymentClient;
+
+    public TossPaymentResponse confirm(PaymentConfirmDTO dto) {


현재 애플리케이션에는 RestClient 빈이 최소 2개(TossPaymentConfig.tossPaymentClient, RestClientConfig.businessWebClient) 존재합니다. 이 상태에서 RestClient 타입을 @Qualifier 없이 주입하면, 컴파일러의 파라미터 이름 보존 여부에 따라 런타임에 DI 후보가 모호해질 수 있습니다. tossPaymentClient 주입 지점에 @Qualifier("tossPaymentClient")(또는 @Primary 지정)로 빈을 명시해 주세요.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@src/main/java/com/eatsfine/eatsfine/domain/payment/service/TossPaymentService.java`:
- Around line 33-41: In TossPaymentService.cancel, avoid string-concatenating
paymentKey into the URI; change the tossPaymentClient.post().uri(...) call to
use a URI template with a placeholder (e.g., "/v1/payments/{paymentKey}/cancel")
and pass paymentKey as the variable so the RestClient will encode reserved
characters properly; keep the subsequent
.body(dto).retrieve().body(TossPaymentResponse.class) behavior unchanged and
ensure you update the uri invocation that currently builds the path with "+"
concatenation.

src/main/java/com/eatsfine/eatsfine/domain/payment/service/TossPaymentService.java

[REFACTOR]: PaymentService 외부 API 호출 로직 분리

bd3c656

zerochani requested review from CokaNuri, SungMinju, Copilot, sonjunkyu and twodo0 January 31, 2026 07:04

zerochani self-assigned this Jan 31, 2026

zerochani added the refactor label Jan 31, 2026

Copilot started reviewing on behalf of zerochani January 31, 2026 07:04 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

coderabbitai bot reviewed Jan 31, 2026

View reviewed changes

src/main/java/com/eatsfine/eatsfine/domain/payment/service/TossPaymentService.java Show resolved Hide resolved

zerochani added 3 commits January 31, 2026 16:50

[FIX]: 결제 승인 API 예외 발생 시 결제 실패 상태 미반영 버그 수정

5945b0d

[FIX]: TossPaymentService 결제 취소 요청 URI 생성 방식 개선

278f5e7

[FIX]: TossPaymentService RestClient 주입 모호성 해결

fd48817

sonjunkyu approved these changes Jan 31, 2026

View reviewed changes

twodo0 approved these changes Jan 31, 2026

View reviewed changes

zerochani merged commit 429f91e into develop Jan 31, 2026
2 checks passed

coderabbitai bot mentioned this pull request Feb 2, 2026

[FEAT] Toss Payments Webhook 연동 및 상태 동기화 로직 구현 #95

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REFACTOR]: PaymentService 외부 API 호출 로직 분리#91

[REFACTOR]: PaymentService 외부 API 호출 로직 분리#91
zerochani merged 4 commits intodevelopfrom
feature/payment

zerochani commented Jan 31, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 31, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	.uri("/v1/payments/" + paymentKey + "/cancel")
	.uri("/v1/payments/{paymentKey}/cancel", paymentKey)

		private final RestClient tossPaymentClient;

		public TossPaymentResponse confirm(PaymentConfirmDTO dto) {

Conversation

zerochani commented Jan 31, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 작업 개요

✅ 작업 내용

🧪 테스트 내용

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zerochani commented Jan 31, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 31, 2026 •

edited

Loading