rn: Clean getPreviousUsers to avoid deprecations#198
Merged
swansontec merged 5 commits intomasterfrom Sep 3, 2020
Merged
Conversation
swansontec
commented
Jun 3, 2020
packages/edge-login-ui-rn/src/common/actions/PreviousUsersActions.js
Outdated
Show resolved
Hide resolved
packages/edge-login-ui-rn/src/common/actions/PreviousUsersActions.js
Outdated
Show resolved
Hide resolved
swansontec
force-pushed
the
william/fix-user-list
branch
3 times, most recently
from
43d1883 to
531be14
Compare
swansontec
requested review from
paullinator
and removed request for
amanalili
swansontec
force-pushed
the
william/fix-user-list
branch
5 times, most recently
from
604049f to
9a321bc
Compare
swansontec
force-pushed
the
william/fix-user-list
branch
from
9a321bc to
b85de12
Compare
swansontec
commented
Sep 2, 2020
The core exposes a user list directly on the context, so there is no need to call methods to get this stuff.
swansontec
force-pushed
the
william/fix-user-list
branch
from
b85de12 to
69facc2
Compare
paullinator
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the core has this stuff as properties, we should avoid using the methods.