Paul/v3 rates and fixes #205
Conversation
Add revolut
Have all plugins just set to undefined for now
paullinator
force-pushed
the
paul/v3RatesAndFixes
branch
from
9b55194 to
f9c86ae
Compare
paullinator
force-pushed
the
paul/v3RatesAndFixes
branch
from
f9c86ae to
1932ac3
Compare
| "start.cache": "node -r sucrase/register src/indexCache.ts", | ||
| "start.rates": "node -r sucrase/register src/indexRates.ts", | ||
| "start.api": "node -r sucrase/register src/indexApi.ts", | ||
| "start.destroyPartition": "node -r sucrase/register src/bin/destroyPartition.ts", |
There was a problem hiding this comment.
Optional
I'd argue to keep the colon over the dot as a separator just because colon has become the de facto standard. Not worth being different from the rest of codebases here.
| datelog(e) | ||
| process.exit(1) | ||
| } | ||
| process.exit(0) |
There was a problem hiding this comment.
The reason why this was hanging is because of we don't cleanup the setTimeout in promiseTimeout util. This should be fixed as a separate commit.
| try { | ||
| tx = asTransfer(rawTx) | ||
| } catch (e) { | ||
| datelog(e) |
There was a problem hiding this comment.
createScopedLog already logs the date ISO string. So this try-catch is unnecessary.
| } | ||
| return standardTx | ||
| } catch (e) { | ||
| datelog(e) |
There was a problem hiding this comment.
Why are we catching just to log and rethrow when createScopedLog is already doing this?
| default: { | ||
| // No token support: | ||
| // these chains don't support tokens | ||
| throw new Error('Tokens are not supported for this chain') |
There was a problem hiding this comment.
| Plugin ID | Token Support Details |
|---|---|
| eos | Has customTokenTemplate - supports custom tokens via contract address |
| telos | Has customTokenTemplate - supports custom tokens via contract address |
| wax | Has customTokenTemplate - supports custom tokens via contract address |
| filecoin | Has customTokenTemplate - supports custom tokens via contract address |
| zano | Has builtinTokens (TALLY, BTCx) and customTokenTemplate for Asset IDs |
These are tokens that Edge may have token support for that will cause this error to through if a transaction is detected with a token. Is that possible? Does the exchange plugins not support token swaps for these chains?
| transaction.depositChainPluginId != null && | ||
| transaction.depositTokenId !== undefined && | ||
| transaction.payoutChainPluginId != null && | ||
| transaction.payoutTokenId !== undefined | ||
| ) { | ||
| return await updateTxValuesV3(transaction) | ||
| } | ||
|
|
||
| if ( | ||
| transaction.depositChainPluginId != null && | ||
| transaction.depositTokenId !== undefined && | ||
| isFiatCurrency(transaction.payoutCurrency) | ||
| ) { | ||
| return await updateTxValuesV3(transaction) | ||
| } | ||
|
|
||
| if ( | ||
| isFiatCurrency(transaction.depositCurrency) && | ||
| transaction.payoutChainPluginId != null && | ||
| transaction.payoutTokenId !== undefined | ||
| ) { | ||
| return await updateTxValuesV3(transaction) | ||
| } |
There was a problem hiding this comment.
Why not one if condition that is a disjunction of the three if conditions?
| await setupDatabase(config.couchDbFullpath, setup, options) | ||
| ) | ||
| ) | ||
| if (config.couchUris == null) { |
There was a problem hiding this comment.
If we're going to require couchUris, then make sure there is some default structure in the config? Otherwise, the commit prehook fails because the tests fail.
| }) | ||
|
|
||
| // v3/rates response cleaner (matches GUI's shape) | ||
| const asV3CryptoAsset = asObject({ |
There was a problem hiding this comment.
Would like these cleaners to be called asRatesV3*.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none