Skip to content

Conversation

@woodkri
Copy link

@woodkri woodkri commented May 1, 2020

@Lomilar Do you mind looking over this before I merge it in? I'm finding it hard to test since I can't do a mvn install in v2 of the editor and so many files are affected.

@woodkri woodkri requested a review from Lomilar May 1, 2020 19:22
@Lomilar
Copy link
Contributor

Lomilar commented Oct 13, 2020

I think this needs to be rebased with the current version of the code.

I'm also confused as to why we need HTTP error messages in an API layer.

@woodkri
Copy link
Author

woodkri commented Oct 13, 2020

Yeah this is out of date now. It came out of T3 requirements that we display certain error messages with certain types of HTTP error codes. I had no way of accessing the code when errors occurred so we were not able to meet those project requirements.

@Lomilar
Copy link
Contributor

Lomilar commented Oct 13, 2020

Does it make sense to use these HTTP error messages in an API definition? I'd probably recommend using an error lookup table or other form of error codes instead.

Up to you as to whether we want to push it forward, there's definitely some impact.

@woodkri
Copy link
Author

woodkri commented Oct 13, 2020

I did it this way because it's what you had recommended at the time. The only reason I was working on this is because it was written into project requirements. You would probably know better than I would if this type of thing is likely to be written into requirements for future projects as well. If not, I think we can drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants