feat(ui): improve accessibility of coverage filters#196
feat(ui): improve accessibility of coverage filters#196EffortlessSteven wants to merge 1 commit intomainfrom
Conversation
- Added `aria-pressed` attribute to coverage filter buttons in `crates/http-platform/src/ui.rs`. - Updated client-side JS to toggle `aria-pressed` state when filters are clicked. - Added `aria-label` to the coverage search input. - Added a new integration test `test_coverage_filters_accessibility` in `crates/app-http/tests/ui_contract_dom.rs` to verify these attributes. - Documented learnings in `.Jules/palette.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Summary by CodeRabbit
WalkthroughChanges add ARIA accessibility attributes (aria-pressed, aria-label) to filter buttons and search input in the Coverage UI. Documentation and a test case validate these accessibility improvements without altering functional filtering behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Improved the accessibility of the AC Coverage page by adding proper ARIA attributes to the filter buttons and search input. The filter buttons now use
aria-pressedto indicate state to screen readers, and the search input has an explicit label. A regression test was added to ensure these attributes persist.PR created automatically by Jules for task 604786190479421793 started by @EffortlessSteven