Skip to content

feat(ui): improve accessibility of coverage filters#196

Draft
EffortlessSteven wants to merge 1 commit intomainfrom
palette-ux-coverage-filters-604786190479421793
Draft

feat(ui): improve accessibility of coverage filters#196
EffortlessSteven wants to merge 1 commit intomainfrom
palette-ux-coverage-filters-604786190479421793

Conversation

@EffortlessSteven
Copy link
Member

Improved the accessibility of the AC Coverage page by adding proper ARIA attributes to the filter buttons and search input. The filter buttons now use aria-pressed to indicate state to screen readers, and the search input has an explicit label. A regression test was added to ensure these attributes persist.


PR created automatically by Jules for task 604786190479421793 started by @EffortlessSteven

- Added `aria-pressed` attribute to coverage filter buttons in `crates/http-platform/src/ui.rs`.
- Updated client-side JS to toggle `aria-pressed` state when filters are clicked.
- Added `aria-label` to the coverage search input.
- Added a new integration test `test_coverage_filters_accessibility` in `crates/app-http/tests/ui_contract_dom.rs` to verify these attributes.
- Documented learnings in `.Jules/palette.md`.
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Summary by CodeRabbit

  • Documentation

    • Added guidance on accessibility improvements for interactive filters in templates.
  • New Features

    • Enhanced filter buttons and search input with ARIA attributes for improved screen reader compatibility.
  • Tests

    • Added automated accessibility validation tests for filter controls and search functionality.

Walkthrough

Changes add ARIA accessibility attributes (aria-pressed, aria-label) to filter buttons and search input in the Coverage UI. Documentation and a test case validate these accessibility improvements without altering functional filtering behavior.

Changes

Cohort / File(s) Summary
Documentation
.Jules/palette.md
Added guidance for pairing ARIA state updates (aria-pressed) with JavaScript class toggles for toggle buttons in Maud templates.
Accessibility Implementation
crates/http-platform/src/ui.rs
Added aria-pressed attributes to filter buttons with JavaScript logic to sync active state, and aria-label to search input for screen reader support.
Accessibility Test
crates/app-http/tests/ui_contract_dom.rs
New test validates ARIA attributes on Coverage page: checks aria-pressed on filter buttons (filter-all, filter-passing, filter-failing, filter-unknown) and aria-label on search input.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through accessibility trees, 🐰
Adding aria-pressed with ease,
Screen readers now hear what buttons do,
Every filter speaks loud and true,
Inclusive web hops into view!


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant