feat(ui): improve accessibility for coverage page#220
feat(ui): improve accessibility for coverage page#220EffortlessSteven wants to merge 2 commits intomainfrom
Conversation
- Added aria-label="Search acceptance criteria" to the search input. - Added aria-pressed attributes to filter buttons (All/Passing/Failing/Unknown). - Updated embedded JavaScript to toggle aria-pressed state on click. - Fixed HTML escaping issue in embedded script and styles by using maud::PreEscaped. - Added integration tests in crates/app-http/tests/ui_accessibility.rs to verify accessibility attributes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Improves the AC Coverage UI page accessibility and fixes inline CSS/JS rendering so client-side filtering/search works reliably with Maud templates.
Changes:
- Wrap inline CSS/JS in
maud::PreEscaped(...)to prevent HTML-escaping from breaking embedded code. - Add
aria-labelto the coverage search input andaria-pressed(plus JS updates) to coverage filter buttons. - Add integration tests validating the rendered coverage page includes the expected accessibility attributes and initial states.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/http-platform/src/ui.rs | Uses PreEscaped for inline <style>/<script>, adds ARIA attributes to coverage controls, and syncs aria-pressed in filter JS. |
| crates/app-http/tests/ui_accessibility.rs | Adds scraper-based integration tests asserting the presence/initial values of coverage ARIA attributes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Ran `cargo fmt` to fix code style issues in `crates/app-http/tests/ui_accessibility.rs` and `crates/http-platform/src/ui.rs`. - Fixed import ordering and line wrapping to satisfy CI lint checks.
Test Results283 tests 245 ✅ 11m 39s ⏱️ Results for commit 214c4e1. |
This PR improves the accessibility of the AC Coverage page by adding proper ARIA attributes to interactive elements.
Changes:
aria-labelto the search input which lacked a visible label.aria-pressedto filter buttons to indicate the active filter state to screen readers.crates/http-platform/src/ui.rswere being HTML-escaped by themaudmacro, breaking the filter functionality. Wrapped them inPreEscaped.crates/app-http/tests/ui_accessibility.rswithscraper-based integration tests to verify the presence and initial state of these attributes.PR created automatically by Jules for task 537960714043794473 started by @EffortlessSteven